-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically increase timenav height when groups demand many rows #259
Comments
I'm also seeing some surprising interactions when I set some of the options which could otherwise address this. This example timeline has 8 groups (including one 'blank') This is the same timeline, with timenav_height=300 Only four group labels are displayed. The markers are displayed as they are otherwise, so some end up in the "wrong" row. This is the same, with timenav_height_percentage=50 It doesn't seem to take up 50%, and it seems like what extra space is available is allocated to the "blank" group Adjustments to |
…issue #259 This could still be an issue https://github.com/NUKnightLab/TimelineJS3/blob/master/source/js/timenav/TL.TimeNav.js#L137 Not sure what effect `max_rows` actually has now.
We should test this with an example that has < 8 groups |
I tried this with a test timeline (not telling a real story) and it seemed OK, but when I tried the example from above, I see a few cases where markers overflow group "lanes." Is that something we can control? |
Thanks, probably an error in my height calculation. |
When people use more than about 4 groups, the allocation of at least one row per-group can lead to crowding in the timenav section.
We should take the number of rows into account and make more space available.
The text was updated successfully, but these errors were encountered: