Skip to content

Conversation

@jonathan-reisdorf
Copy link
Collaborator

@jonathan-reisdorf jonathan-reisdorf commented Jul 6, 2022

Attempt to upgrade dependencies listed in #15

❗ untested, no local backend set up to test anymore. Build works and UI seems to work as expected. cc @mbastian93

Note: To upgrade @d4l/web-components-library to v3, package @stencil/router would have to be replaced with https://github.com/ionic-team/stencil-router-v2. However, development on the v2 router was recently dropped for lack of maintainers. The v2 router itself works just fine, has a very small and clean code base and provides plenty of improvements over the v1 router (it will also remove a lot of warnings in the DevTools console currently coming from the v1 version), that's why D4L's web components library decided to upgrade to it despite it never having officially reached a final version.

@mbastian93
Copy link
Contributor

mbastian93 commented Jul 6, 2022

It seems like the used version of stencil is not compatible with the used version of jest; running npm test results in

[56:58.4]  @stencil/core
[56:58.7]  v2.17.0 🚂

[ ERROR ]  Please install supported versions of dev dependencies with either npm or yarn.
           npm install --save-dev @types/jest@27.0.3 jest@27.0.3 jest-cli@27.4.5

@jonathan-reisdorf
Copy link
Collaborator Author

Thank you, I have now downgraded the jest dependencies accordingly

@mbastian93 mbastian93 merged commit 67c9772 into main Jul 6, 2022
@jonathan-reisdorf jonathan-reisdorf deleted the chore/upgrade-deps branch July 6, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants