New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added type checking support #70

Merged

lowitea merged 3 commits into NUTtech:develop from aswinmurali-io:develop

Oct 18, 2021

Contributor

aswinmurali-io commented Oct 18, 2021 •

edited by lowitea

Loading

Related Issue: #4
closes #4

Added mypy as dev dependency.
Added stub files for django, request, celery.
Added mypy.yml for type checking CI.

Should I update the CHANGELOG.md file?

aswinmurali-io added 2 commits

October 18, 2021 11:31


          Add mypy and stub packages

7b9218f


          Add mypy type checking CI

b46af30

codecov bot commented Oct 18, 2021 •

edited

Loading

Codecov Report

Merging #70 (242fe13) into develop (82a30e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #70   +/-   ##
========================================
  Coverage    96.29%   96.29%           
========================================
  Files            7        7           
  Lines          189      189           
  Branches        15       15           
========================================
  Hits           182      182           
  Misses           5        5           
  Partials         2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a30e5...242fe13. Read the comment docs.

lowitea reviewed

View reviewed changes

.github/workflows/mypy.yml Outdated Show resolved Hide resolved

lowitea added the hacktoberfest-accepted label


          Update mypy CI to trigger on pull request

242fe13

Co-authored-by: lowitea <lonewitcher@gmail.com>

sonarqubecloud bot commented Oct 18, 2021

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Contributor Author

aswinmurali-io commented Oct 18, 2021

Updated the changes. @lowitea

lowitea added this to the 2.0.0 milestone

Contributor

lowitea commented Oct 18, 2021 •

edited

Loading

Should I update the CHANGELOG.md file?

No thanks, when I collect the tasks in the release, I will update it myself.

lowitea approved these changes

View reviewed changes

lowitea merged commit 9182b5c into NUTtech:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted