Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating mysql2 to version 2.2.5 breaks mysql-import.js #161

Closed
csmig opened this issue Feb 22, 2021 · 0 comments · Fixed by #372
Closed

Updating mysql2 to version 2.2.5 breaks mysql-import.js #161

csmig opened this issue Feb 22, 2021 · 0 comments · Fixed by #372
Assignees
@csmig
Labels
API good first issue Good for newcomers maintenance Unused files, methods, etc.

Comments

@csmig
Copy link
Member

csmig commented Feb 22, 2021 •
edited
Loading

Updating mysql2 to version 2.2.5 breaks mysql-import.js. Will need to rewrite this line to not use a callback interface.

Originally posted by @csmig in #158 (comment)
@csmig csmig added API maintenance Unused files, methods, etc. labels Feb 22, 2021
@csmig csmig mentioned this issue Apr 21, 2021
Closed
@cd-rite cd-rite added this to the Out of Beta milestone Jun 13, 2021
@cd-rite cd-rite removed this from the Out of Beta milestone Jun 16, 2021
@csmig csmig added the good first issue Good for newcomers label Jun 23, 2021
@csmig csmig self-assigned this Jul 26, 2021
@csmig csmig changed the title Updating mysql2 to version 2.2.25 breaks mysql-import.js Updating mysql2 to version 2.2.5 breaks mysql-import.js Jul 28, 2021
csmig added a commit to csmig/stig-manager that referenced this issue Jul 28, 2021
@csmig
fix: use promise interface for conn.query() (NUWCDIVNPT#161)
86aadeb
@csmig csmig mentioned this issue Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csmig csmig

Labels
API good first issue Good for newcomers maintenance Unused files, methods, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use promise interface for conn.query() in mysql-import csmig/stig-manager
2 participants
@csmig @cd-rite