Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for USMC MCCAST formatted POAM export in STIG Manager #1345

Merged
merged 17 commits into from
Aug 28, 2024

Conversation

whalenda
Copy link
Contributor

@whalenda whalenda commented Aug 3, 2024

Closes #1174 by adding support for exporting POAMs in MCCAST format. Adds a template .xlsx file for the MCCAST format, necessary API support to populate the template on request, and updates the Web UI to allow for the selection of either POAM format on export.

@whalenda whalenda changed the title Add Support for the USMC MCCAST POAM export in STIG Manager Add Support for USMC MCCAST formatted POAM export in STIG Manager Aug 3, 2024
@whalenda
Copy link
Contributor Author

whalenda commented Aug 3, 2024

I put this up as a draft, as I'm still working out the test cases for the API updates, however I've added my email to the Contributors.md file so that you can validate you can reach me at it. Thanks again for the help @cd-rite!

@csmig
Copy link
Member

csmig commented Aug 5, 2024

It's looking very good, thanks much for the contribution. I did a first pass over the code with @cd-rite today, we can provide more detailed feedback in a bit. Chris can also explain our still developing processes around this, our first community contribution. Welcome aboard!

@cd-rite
Copy link
Collaborator

cd-rite commented Aug 12, 2024

Hi @whalenda I've pushed a few changes to your branch:

  • Removed a few out-of-scope changes
  • Added poam type to generated filename
  • Added an enum restricting poam format to either "EMASS" or "MCCAST"
  • Set "EMASS" as the default if no format specified
  • Some basic restrictions on the size of the query params to this endpoint (basically, set maxLength of strings to 255 chars)

If you are happy with these changes, you can hit the "Ready for Review" button on this PR, and then @csmig should be able to add any Review comments.
Thanks!

@whalenda whalenda marked this pull request as ready for review August 25, 2024 19:57
@cd-rite cd-rite requested a review from csmig August 26, 2024 13:37
@csmig
Copy link
Member

csmig commented Aug 28, 2024

Thanks again for the contribution. I've added a couple more commits, one just merges against the current HEAD of main. The other heavily refactors the UI source so it follows our current best practices. We hadn't touched these files in years and they needed better organization. The UI files are hopefully more maintainable now, BZs to @whalenda for understanding the logic in the originals.

I also added the ability in the browser to remember the last POAM format generated and open the POAM options with that format pre-selected.

I made minor changes to the API code, mostly to simplify and for readability.

@csmig csmig merged commit 2c56ce1 into NUWCDIVNPT:main Aug 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE REQUEST: Support for the USMC MCCAST POAM export in STIG Manager
3 participants