Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete stig now deletes records in related tables and updates statistics #409

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

russdj
Copy link
Contributor

@russdj russdj commented Aug 19, 2021

resolves #391

@csmig
Copy link
Member

csmig commented Aug 20, 2021

@russdj . Thanks, looks good. If we end up making more commits to this (see question to Chris below), we might want to make DELETE from stig... the first query. We could therefore remove the explicit DELETE from revision... since the STIG delete will cascade there. But let's see if we want to spend any more time on this PR...

@cd-rite The newman test is very sparse here, just checks for 200. Deleting a STIG initiates cascading deletes that could/should be verified:

  • STIG/Asset assignments
  • Level 1 access grants

Should we try to get a more robust test into this PR, or delay and make a new issue?

@cd-rite
Copy link
Collaborator

cd-rite commented Aug 23, 2021

I've created a new issue for the tests. #410

@csmig csmig merged commit a7b17f5 into NUWCDIVNPT:main Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a STIG should recalculate statistics
3 participants