Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: client distribution build script #534

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Conversation

csmig
Copy link
Member

@csmig csmig commented Jan 2, 2022

  • Changes the client source directory from clients/extjs to client/src
  • Adds an empty client distribution directory client/dist
  • Adds a build script client/build.sh that creates the minified web client distribution.
  • Changes Dockerfile to copy client/dist (instead of clients/extjs) to ./client
  • Adds a reusable GitHub workflow build-client.yml that calls client/build.sh.
  • Changes the workflow pub-docker.yml to need and use build-client.yml prior to building container images
  • Changes the workflow pub-docker.yml to specify the target DockerHub repository with workflow env DOCKERHUB_REPOSITORY
  • Changes the workflow pub-docker.yml to checkout the repo with fetch-depth: 0 which removes the need to execute git fetch --prune --unshallow in a later step

@csmig csmig merged commit 7fad835 into NUWCDIVNPT:main Jan 4, 2022
@csmig csmig mentioned this pull request Jan 5, 2022
@csmig csmig deleted the build-client-pr branch May 4, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant