Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds Collection.settings #548

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Conversation

csmig
Copy link
Member

@csmig csmig commented Jan 11, 2022

Resolves #434
Resolves #547

  • Updates the OAS definition to include Collection.settings and removes Collection.workflow
  • Updates the API, client, and Postman tests to use the new schema

@cd-rite
Copy link
Collaborator

cd-rite commented Jan 11, 2022

Error popup in Client when disabling Review Accept/Reject from the App Manager Collection Management screen:
Application Management->Collections->Modify Collection Properties:
Unselect "Reviews can be Accepted or Rejected" on any Collection where it is already selected and hit "Update"
Works fine from "Manage" Collection interface, or when ENabling review accept/reject.

image

@cd-rite
Copy link
Collaborator

cd-rite commented Jan 11, 2022

Application Management->Collections->Modify Collection Properties:
Grant required to set Accept or Reject: Always shows "Manage or Owner" no matter what the actual setting is.
You can make a change with the pull down to "Owner" and it will be reflected in the DB and individual Collection Management interface, but will still show "Manage or Owner" when next opened in the App Management Collection interface.

@cd-rite
Copy link
Collaborator

cd-rite commented Jan 12, 2022

Confirmed the latest commit resolves both issues mentioned in my comments.

@csmig csmig merged commit 675e031 into NUWCDIVNPT:main Jan 12, 2022
@csmig csmig deleted the collection-settings branch January 12, 2022 15:54
@csmig csmig mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Description not updated on post (Create Collection method of API) Add a settings property to Collection
2 participants