Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use multi-stage builds to create our containers #227

Closed
3 tasks
jperez999 opened this issue Apr 20, 2022 · 0 comments · Fixed by #234
Closed
3 tasks

Use multi-stage builds to create our containers #227

jperez999 opened this issue Apr 20, 2022 · 0 comments · Fixed by #234
Assignees
@karlhigley @jperez999
Labels
enhancement New feature or request

Comments

@jperez999
Copy link
Collaborator

jperez999 commented Apr 20, 2022 •
edited
Loading

Create two containers one that builds all the assets and a second clean container. Then copy all binaries from container where builds occurred to fresh container. COPY ONLY BUILD binaries, This will ensure the smallest docker container size.

  • Create container that builds all artifacts (start from tritonserver container)
  • Create clean base container
  • Copy binaries from build container to fresh container.
@jperez999 jperez999 mentioned this issue Apr 20, 2022
Closed
15 tasks
@jperez999 jperez999 changed the title Ensure we are using DLFW best practices to create our containers (i.e. build binaries and copy to fresh container) Use DLFW best practices to create our containers Apr 20, 2022
@karlhigley karlhigley added the enhancement New feature or request label Apr 21, 2022
@jperez999 jperez999 linked a pull request Apr 22, 2022 that will close this issue
Container revamp #231
Closed
@karlhigley karlhigley linked a pull request Apr 25, 2022 that will close this issue
Restructure container builds to use multi-stage builds and a Merlin base image #234
Merged
@karlhigley karlhigley changed the title Use DLFW best practices to create our containers Use multi-stage builds to create our containers Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlhigley karlhigley

@jperez999 jperez999

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@karlhigley @jperez999