-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure container builds to use multi-stage builds and a Merlin base image #234
Conversation
We just needed to install a few system packages
7415f3b
to
83307db
Compare
Documentation preview |
Click to view CI ResultsGitHub pull request #234 of commit 83307dba3e23fae9f1a68f30b840c44dc9d4369f, no merge conflicts. Running as SYSTEM Setting status of 83307dba3e23fae9f1a68f30b840c44dc9d4369f to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/47/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/234/*:refs/remotes/origin/pr/234/* # timeout=10 > git rev-parse 83307dba3e23fae9f1a68f30b840c44dc9d4369f^{commit} # timeout=10 Checking out Revision 83307dba3e23fae9f1a68f30b840c44dc9d4369f (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 83307dba3e23fae9f1a68f30b840c44dc9d4369f # timeout=10 Commit message: "Add a container test for HugeCTR" > git rev-list --no-walk 9f88235c76a3e8eaf14142179b2422ba2737a9a6 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins8788969305069239975.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.1, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 1 item |
This also adds container tests with container-structure-test.
Final sizes of the combined training/inference containers for each framework: