Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed preprocessing and training scripts in Quick-start for Ranking #1017

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

gabrielspmoreira
Copy link
Member

  • Fixes preprocessing.py, which was not standardizing and tagging continuous columns properly
  • Fixing Wide&Deep and DeepFM models to use the updated API

…us columns properly and fixing W&D and DeepFM models to use the updated API
@gabrielspmoreira gabrielspmoreira self-assigned this Jun 20, 2023
@gabrielspmoreira gabrielspmoreira requested a review from rnyak June 20, 2023 01:20
@gabrielspmoreira gabrielspmoreira added the bug Something isn't working label Jun 20, 2023
@gabrielspmoreira gabrielspmoreira added this to the Merlin 23.06 milestone Jun 20, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-1017

@gabrielspmoreira gabrielspmoreira merged commit 8c9fbff into main Jun 20, 2023
gabrielspmoreira added a commit that referenced this pull request Jun 20, 2023
…1017)

* Fixed preprocessing, which was not standardizing and tagging continuous columns properly and fixing W&D and DeepFM models to use the updated API

* Updated example command for ranking.py

* Moving indexing after filter
@rnyak rnyak deleted the quick_start_quick_fixes branch June 20, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants