Move Next-Item-Prediction-with-Transformers examples from models #1028
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation preview |
radekosmulski
force-pushed
the
move_examples_from_merlin_models
branch
3 times, most recently
from
4ef93e7 to
84bb641
Compare
| timeout=720, | ||
| execute=False, | ||
| ) | ||
| @pytest.mark.notebook |
There was a problem hiding this comment.
This throws a warning (not an error) in the logs:
tests/unit/test_transformers_next_item_prediction_with_pretrained_embeddings.py:21
/home/gha-user/gha1/Merlin/Merlin/tests/unit/test_transformers_next_item_prediction_with_pretrained_embeddings.py:21: PytestUnknownMarkWarning: Unknown pytest.mark.notebook - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
@pytest.mark.notebook
You can add a notebook marker here: https://github.com/NVIDIA-Merlin/Merlin/blob/main/pytest.ini to stop the warning.
There was a problem hiding this comment.
thank you ver much for looking at this @nv-alaiacano! 🙏 will make the changes today
The GPU CI pipeline that was failing for me the whole day (which I posted about in slack) passed on the last run! (I left it running as I shut down for the day but had no hope it would pass as it failed with the same error for me 5+ times yesterday, but turns out it now passes!)
Thank you very much for looking into this anyhow and for spotting this issue and pointing me how to get rid of the warnings, will do so today 🙂
radekosmulski
force-pushed
the
move_examples_from_merlin_models
branch
from
cfb9764 to
2b21651
Compare
|
What are the changes in |
radekosmulski
force-pushed
the
move_examples_from_merlin_models
branch
from
151fea3 to
67b681a
Compare
|
Thank you very much for catching this, Benedikt! My bad. I have now removed the file. |
* Move over the examples * Move over tests (along with the asvdb benchmark tracking test) * Add `notebook` marker to pytest.ini * Update tracking logo on the example with pretrained embeddings
radekosmulski
force-pushed
the
move_examples_from_merlin_models
branch
from
67b681a to
b85747b
Compare
This is a part of larger ongoing work that we are tracking under #1027.
Here I am only moving the examples from
modelstoMerlinand making sure the tests run. Once this is in place, I'll work on merging a PR in models to remove the examples and clean up tests, etc.