Enable cross-compiling for x86 + NVIDIA Grace (ARM64) #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the dockerfile for new upstream
…to fix-update_base_23.05
Documentation preview |
bashimao
commented
Jul 13, 2023
bashimao
commented
Jul 13, 2023
bashimao
commented
Jul 13, 2023
bashimao
commented
Jul 13, 2023
bashimao
commented
Jul 13, 2023
|
@jperez999 @EmmaQiaoCh @minseokl I wish this could be merged ;-) |
jperez999
approved these changes
Jul 17, 2023
bashimao
force-pushed
the
fix-arm-support
branch
from
58b1559 to
6d4c453
Compare
|
I am going to push this through as the failure does not have anything to do with the docker files edited in this PR. We will see if this runs successfully in our Pipeline and revert if we have any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix build up on our previous fixes. It will bring back arm compiling, but this time we take a more wholesome approach.
Also, this change removes some redundancies that were in the build process.
Depends on
#1043