deactivate merlin repo integration tests for merlin-tensorflow container #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deactivates the merlin repo integration tests because they are crashing. These tests need to be reviewed and also the testbook notebook tests are not working as expected anymore. The injected blocks of code cannot reference objects created within the context of the notebook execution, that were run before the injection. Testbook is not a package that has been kept up- to-date and jupyter is continuously updated. This mismatch may be a an issue. Until we can figure it out, we will try to skip the integration tests for the merlin-tensorflow container only.