Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request/1064 #1069

Merged
merged 8 commits into from
Sep 21, 2023
Merged

Pull request/1064 #1069

merged 8 commits into from
Sep 21, 2023

Conversation

EmmaQiaoCh
Copy link
Contributor

No description provided.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 21, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-1069

@EmmaQiaoCh EmmaQiaoCh added 23.09 bug Something isn't working labels Sep 21, 2023
bashimao
bashimao approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@bashimao bashimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmaQiaoCh EmmaQiaoCh merged commit 64966c5 into main Sep 21, 2023
9 of 12 checks passed
@copy-pr-bot copy-pr-bot bot deleted the pull-request/1064 branch September 24, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashimao bashimao bashimao approved these changes

@jperez999 jperez999 Awaiting requested review from jperez999

Assignees
No one assigned
Labels
23.09 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmmaQiaoCh @bashimao