Rel 22.03 #124
Merged
Rel 22.03 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the "update jackson databind and remove log4j" part
remove "update jackson databind and rm log4j"
Delete Hadoop installer for v3.5
EvenOldridge
approved these changes
Mar 4, 2022
| @@ -1,5 +1,5 @@ | |||
| # syntax=docker/dockerfile:1.2 | |||
| ARG TRITON_VERSION=22.01 | |||
| ARG TRITON_VERSION=22.02 | |||
There was a problem hiding this comment.
Do we want to make this a range? >= ?
There was a problem hiding this comment.
This is a variable, it it not a comparison, it is an assignation
| @@ -44,7 +46,7 @@ RUN ln -s /usr/bin/python3 /usr/bin/python | |||
| # Install multiple packages | |||
| RUN pip install cupy-cuda115 nvidia-pyindex pybind11 pytest protobuf transformers==4.12 tensorflow-metadata | |||
| RUN pip install betterproto cachetools graphviz nvtx scipy sklearn | |||
| RUN pip install numba --no-deps | |||
| RUN pip install pandas numba==0.55.1 numpy==1.21.5 | |||
There was a problem hiding this comment.
Do we need to fix versions here?
There was a problem hiding this comment.
For now we need to change them before installin Merlin Software. We need to update Merlin Software prerequisites
| mv jackson-databind-2.13.1.jar /usr/local/hadoop/share/hadoop/common/lib/ && \ | ||
| rm /usr/local/hadoop/share/hadoop/common/lib/log4j-1.2.17.jar && rm /usr/local/hadoop/share/hadoop/hdfs/lib/log4j-1.2.17.jar | ||
| mv ./hadoop-3.3.1 /usr/local/hadoop && cd /usr/local/lib/ && ln -s libhdfs.so.0.0.0 libhdfs.so ; \ | ||
| fi | ||
|
|
||
| ENV JAVA_HOME=/usr/java/jdk-16.0.2 |
There was a problem hiding this comment.
Do we even need java if we're not installing hdfs?
There was a problem hiding this comment.
HugeCTR wanted to keep it as optional. They will be using it for dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.