Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial attempt at support matrices #182

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

mikemckiernan
Copy link
Member

  • Use Alberto's workstation for bandwidth.
  • Extract the broad swath of data from
    the NGC containers.
  • Create RST tables from the data.

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #182 of commit d6d20dfd60bb7788721cb665bf5b455c2bb91283, no merge conflicts.
Running as SYSTEM
Setting status of d6d20dfd60bb7788721cb665bf5b455c2bb91283 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/4/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/182/*:refs/remotes/origin/pr/182/* # timeout=10
 > git rev-parse d6d20dfd60bb7788721cb665bf5b455c2bb91283^{commit} # timeout=10
Checking out Revision d6d20dfd60bb7788721cb665bf5b455c2bb91283 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d6d20dfd60bb7788721cb665bf5b455c2bb91283 # timeout=10
Commit message: "docs: initial tooling for container matrices"
 > git rev-list --no-walk df5a0ee9bcdb4013ddc2538506e4fb075846b5ce # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins6656464598325244644.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.1, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.02s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins7232071102787388548.sh

@github-actions
Copy link

github-actions bot commented Apr 2, 2022

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-182

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #182 of commit d0c5c6e1ac244f939a18c51fc0ca4072f5ccf522, no merge conflicts.
Running as SYSTEM
Setting status of d0c5c6e1ac244f939a18c51fc0ca4072f5ccf522 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/5/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/182/*:refs/remotes/origin/pr/182/* # timeout=10
 > git rev-parse d0c5c6e1ac244f939a18c51fc0ca4072f5ccf522^{commit} # timeout=10
Checking out Revision d0c5c6e1ac244f939a18c51fc0ca4072f5ccf522 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d0c5c6e1ac244f939a18c51fc0ca4072f5ccf522 # timeout=10
Commit message: "docs: initial tooling for container matrices"
 > git rev-list --no-walk d6d20dfd60bb7788721cb665bf5b455c2bb91283 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins771916005454143425.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.1, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins4249254767671227300.sh

* Use Alberto's workstation for bandwidth.
* Extract the broad swath of data from
  the NGC containers.
* List container size in GB. Yay!
* Create RST tables from the data.
* Create one page for each container.
@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #182 of commit 94f230c7cc1d8f95e5c285eb91ed97ed4534e700, no merge conflicts.
Running as SYSTEM
Setting status of 94f230c7cc1d8f95e5c285eb91ed97ed4534e700 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/6/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/182/*:refs/remotes/origin/pr/182/* # timeout=10
 > git rev-parse 94f230c7cc1d8f95e5c285eb91ed97ed4534e700^{commit} # timeout=10
Checking out Revision 94f230c7cc1d8f95e5c285eb91ed97ed4534e700 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 94f230c7cc1d8f95e5c285eb91ed97ed4534e700 # timeout=10
Commit message: "docs: initial tooling for container matrices"
 > git rev-list --no-walk d0c5c6e1ac244f939a18c51fc0ca4072f5ccf522 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins8475377898410435067.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.1, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins6704226624200723700.sh

@mikemckiernan
Copy link
Member Author

mikemckiernan commented Apr 3, 2022

Small changes are OK. Corrections and concerns about the software versions are welcome.

I'm certainly surprised at some of the answers. Maybe I have a misunderstanding about what should be where.

docker run --rm -it nvcr.io/nvidia/merlin/merlin-tensorflow-inference:22.03 python -c 'import tensorflow as x; print(x.__version__);'

After the banner, the preceding command reports the following:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'tensorflow'

That is why the https://nvidia-merlin.github.io/Merlin/review/pr-182/support_matrix/support_matrix_merlin_tensorflow_inference.html page shows "Not applicable" for TensorFlow. Suggestions welcome.

@karlhigley
Copy link
Contributor

@mikemckiernan You're right to call that out—I think that's the result of a known issue that happened while splitting the unified inference container from 22.02 into separate inference containers per framework for 22.03 though. It looks like this is getting tested and fixed in the 22.04 release.

@karlhigley karlhigley merged commit 9702f88 into NVIDIA-Merlin:main Apr 4, 2022
@karlhigley karlhigley added this to the Merlin 22.04 milestone Apr 4, 2022
@karlhigley karlhigley added the documentation Improvements or additions to documentation label Apr 4, 2022
@EvenOldridge
Copy link
Member

This looks good @mikemckiernan. Thanks @karlhigley for stewarding and merging.

@mikemckiernan mikemckiernan deleted the docs-smx branch July 5, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants