Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on errors in test_container.sh #194

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Fail on errors in test_container.sh #194

merged 1 commit into from
Apr 11, 2022

Conversation

benfred
Copy link
Member

@benfred benfred commented Apr 7, 2022

If one of the scripts in test_container.sh fails, or can't be run
we ended up reporting success. Change to bubble up the error, and
fail the entire test run.

We hit this problem with the hugectr tests being missing, but the
overall test_container.sh run looked successful.

If one of the scripts in test_container.sh fails, or can't be run
we ended up reporting success. Change to bubble up the error, and
fail the entire test run.

We hit this problem with the hugectr tests being missing, but the
overall test_container.sh run looked successful.
@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #194 of commit 4fe1c7ab0cd275602bde317c79bfef9c0f1c63a1, no merge conflicts.
Running as SYSTEM
Setting status of 4fe1c7ab0cd275602bde317c79bfef9c0f1c63a1 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/32/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/194/*:refs/remotes/origin/pr/194/* # timeout=10
 > git rev-parse 4fe1c7ab0cd275602bde317c79bfef9c0f1c63a1^{commit} # timeout=10
Checking out Revision 4fe1c7ab0cd275602bde317c79bfef9c0f1c63a1 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 4fe1c7ab0cd275602bde317c79bfef9c0f1c63a1 # timeout=10
Commit message: "Fail on errors in test_container.sh"
 > git rev-list --no-walk 7cbf32465f22730164ce78daae70110ba9c6fa42 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins2992963458281340118.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.1, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins8343318492162452210.sh

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-194

@benfred benfred requested a review from albert17 April 7, 2022 19:24
Copy link
Member

@EvenOldridge EvenOldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@albert17 albert17 merged commit 90698bd into main Apr 11, 2022
@benfred benfred deleted the fail_on_errors branch April 11, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants