Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace run_ensemble_on_tritonserver() with send_triton_request() and do minor updates #244

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

rnyak
Copy link
Contributor

@rnyak rnyak commented Apr 26, 2022

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #244 of commit 56f0bfb383c158bab7eea599ed285f3456626429, no merge conflicts.
Running as SYSTEM
Setting status of 56f0bfb383c158bab7eea599ed285f3456626429 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/48/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/244/*:refs/remotes/origin/pr/244/* # timeout=10
 > git rev-parse 56f0bfb383c158bab7eea599ed285f3456626429^{commit} # timeout=10
Checking out Revision 56f0bfb383c158bab7eea599ed285f3456626429 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 56f0bfb383c158bab7eea599ed285f3456626429 # timeout=10
Commit message: "update inf nbs"
 > git rev-list --no-walk 83307dba3e23fae9f1a68f30b840c44dc9d4369f # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins555335543446279292.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.1, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins2889300295260397729.sh

@rnyak rnyak requested a review from karlhigley April 26, 2022 19:33
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-244

@rnyak rnyak requested a review from bschifferer April 26, 2022 19:37
@karlhigley
Copy link
Contributor

LGTM for swapping one method out with another

@@ -106,9 +106,19 @@
"### Import required libraries and functions"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is BASE_DIRE defined? Should that not crash?


Reply via ReviewNB

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind - ReviewNB had the section collapsed and therefore, I did not see it.

bschifferer
bschifferer approved these changes Apr 27, 2022
@jperez999 jperez999 merged commit 509e0ea into main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants