Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add args, ARG can only handle one arg at a time #245

Merged
merged 1 commit into from
Apr 26, 2022
Merged

add args, ARG can only handle one arg at a time #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions docker/inference/dockerfile.ctr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,13 +238,13 @@ RUN git clone https://github.com/NVIDIA-Merlin/nvtabular_triton_backend.git buil
# -----------------------------------------------------------------------------
# HugeCTR + Dependencies

ARG HIREDIS_VER=1.0.2 \
REDIS_PP_VER=1.3.3 \
ROCKSDB_VER=6.29.3 \
RDKAFKA_VER=1.8.2 \
# Optional.
PROTOC_VER=3.19.4 \
HADOOP_VER=3.3.2
ARG HIREDIS_VER=1.0.2
ARG REDIS_PP_VER=1.3.3
ARG ROCKSDB_VER=6.29.3
ARG RDKAFKA_VER=1.8.2
# Optional.
ARG PROTOC_VER=3.19.4
ARG HADOOP_VER=3.3.2

# Dependency: Build and install Redis native client.
RUN git clone --branch v${HIREDIS_VER} --depth 1 https://github.com/redis/hiredis.git hiredis && \
Expand Down Expand Up @@ -283,8 +283,8 @@ RUN git clone --branch v${RDKAFKA_VER} --depth 1 https://github.com/edenhill/lib
rm -rf rdkafka

# Optional dependency: Build and install protocol buffers and Hadoop/HDFS.
ARG INSTALL_HDFS=false \
BUILD_HADOOP=false
ARG INSTALL_HDFS=false
ARG BUILD_HADOOP=false

RUN git clone --branch v${PROTOC_VER} --depth 1 https://github.com/protocolbuffers/protobuf.git protobuf && \
cd protobuf && \
Expand Down
16 changes: 8 additions & 8 deletions docker/training/dockerfile.ctr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,12 @@ RUN mkdir -p /var/tmp && wget -q -nc --no-check-certificate -P /var/tmp https://
# HugeCTR + Dependencies

ARG HIREDIS_VER=1.0.2 \
REDIS_PP_VER=1.3.3 \
ROCKSDB_VER=6.29.3 \
RDKAFKA_VER=1.8.2 \
# Optional.
PROTOC_VER=3.19.4 \
HADOOP_VER=3.3.2
ARG REDIS_PP_VER=1.3.3 \
ARG ROCKSDB_VER=6.29.3 \
ARG RDKAFKA_VER=1.8.2 \
# Optional.
ARG PROTOC_VER=3.19.4 \
ARG HADOOP_VER=3.3.2

# Dependency: Build and install Redis native client.
RUN git clone --branch v${HIREDIS_VER} --depth 1 https://github.com/redis/hiredis.git hiredis && \
Expand Down Expand Up @@ -158,8 +158,8 @@ RUN git clone --branch v${RDKAFKA_VER} --depth 1 https://github.com/edenhill/lib
rm -rf rdkafka

# Optional dependency: Build and install protocol buffers and Hadoop/HDFS.
ARG INSTALL_HDFS=false \
BUILD_HADOOP=false
ARG INSTALL_HDFS=false
ARG BUILD_HADOOP=false

RUN git clone --branch v${PROTOC_VER} --depth 1 https://github.com/protocolbuffers/protobuf.git protobuf && \
cd protobuf && \
Expand Down