Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove horovod from torch container #249

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

jperez999
Copy link
Collaborator

removing horovod from torch container as it is not supported internally at Nvidia for torch.

@jperez999 jperez999 requested a review from karlhigley April 28, 2022 15:59
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-249

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #249 of commit 80ae7e79d80a714e344f34e71bf4a900f144d88e, no merge conflicts.
Running as SYSTEM
Setting status of 80ae7e79d80a714e344f34e71bf4a900f144d88e to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/52/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/249/*:refs/remotes/origin/pr/249/* # timeout=10
 > git rev-parse 80ae7e79d80a714e344f34e71bf4a900f144d88e^{commit} # timeout=10
Checking out Revision 80ae7e79d80a714e344f34e71bf4a900f144d88e (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 80ae7e79d80a714e344f34e71bf4a900f144d88e # timeout=10
Commit message: "remove horovod from torch container"
 > git rev-list --no-walk 69e5a01b0c6d98d1c61afcc0d0600df59b6f3aef # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins3280575146640225224.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.1, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins1417992039952077870.sh

@karlhigley
Copy link
Contributor

If we're going to remove it, I'd just delete the line

@karlhigley karlhigley merged commit 10e24f6 into NVIDIA-Merlin:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants