Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit test for Building and deploying multi-stage Recsys nbs #281

Merged
merged 4 commits into from
May 5, 2022

Conversation

rnyak
Copy link
Contributor

@rnyak rnyak commented May 4, 2022

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #281 of commit c244ae3b4e2e7f1ff6499a5e5d6254f36b8136eb, no merge conflicts.
Running as SYSTEM
Setting status of c244ae3b4e2e7f1ff6499a5e5d6254f36b8136eb to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/63/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/281/*:refs/remotes/origin/pr/281/* # timeout=10
 > git rev-parse c244ae3b4e2e7f1ff6499a5e5d6254f36b8136eb^{commit} # timeout=10
Checking out Revision c244ae3b4e2e7f1ff6499a5e5d6254f36b8136eb (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f c244ae3b4e2e7f1ff6499a5e5d6254f36b8136eb # timeout=10
Commit message: "add unit test for poc_nbs"
 > git rev-list --no-walk ab825d37fe8d7b8b9b7bcd0515dd4c288543f2d8 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins4655212979495614157.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins1080982273526761506.sh

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #281 of commit 7228754f6ba4febc4bc610f37a668c64df7e6104, no merge conflicts.
Running as SYSTEM
Setting status of 7228754f6ba4febc4bc610f37a668c64df7e6104 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/64/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/281/*:refs/remotes/origin/pr/281/* # timeout=10
 > git rev-parse 7228754f6ba4febc4bc610f37a668c64df7e6104^{commit} # timeout=10
Checking out Revision 7228754f6ba4febc4bc610f37a668c64df7e6104 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 7228754f6ba4febc4bc610f37a668c64df7e6104 # timeout=10
Commit message: "Delete tmp_cell-checkpoint.py"
 > git rev-list --no-walk c244ae3b4e2e7f1ff6499a5e5d6254f36b8136eb # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins7954749394366781839.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins1919641883121877196.sh

@github-actions
Copy link

github-actions bot commented May 4, 2022

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-281

@karlhigley karlhigley added this to the Merlin 22.05 milestone May 5, 2022
@karlhigley karlhigley merged commit 5417a70 into main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants