Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm nvm #296

Merged
merged 9 commits into from
May 9, 2022
Merged

Rm nvm #296

merged 9 commits into from
May 9, 2022

Conversation

jperez999
Copy link
Collaborator

remove nvm from the dlfw containers to see if that messes anything up for us. If not we should be able to get back the AAA rating.

@jperez999 jperez999 requested a review from benfred May 9, 2022 19:53
@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #296 of commit b9424e5e6930da5686cfed3165ab24e5545f3656, no merge conflicts.
Running as SYSTEM
Setting status of b9424e5e6930da5686cfed3165ab24e5545f3656 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/75/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/296/*:refs/remotes/origin/pr/296/* # timeout=10
 > git rev-parse b9424e5e6930da5686cfed3165ab24e5545f3656^{commit} # timeout=10
Checking out Revision b9424e5e6930da5686cfed3165ab24e5545f3656 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f b9424e5e6930da5686cfed3165ab24e5545f3656 # timeout=10
Commit message: "remove nvm for triple a rating"
 > git rev-list --no-walk 4b9aeb223f1b0677b696d34168751958d7f78549 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins7254126079653064768.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins8898184116264998714.sh

@github-actions
Copy link

github-actions bot commented May 9, 2022

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-296

@jperez999 jperez999 merged commit ccdb162 into NVIDIA-Merlin:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants