Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container infos to notebooks #298

Merged
merged 2 commits into from
May 11, 2022

Conversation

bschifferer
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #298 of commit 5a590698f83840385425c2c8a7cfed8a6f21e970, no merge conflicts.
Running as SYSTEM
Setting status of 5a590698f83840385425c2c8a7cfed8a6f21e970 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/77/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/298/*:refs/remotes/origin/pr/298/* # timeout=10
 > git rev-parse 5a590698f83840385425c2c8a7cfed8a6f21e970^{commit} # timeout=10
Checking out Revision 5a590698f83840385425c2c8a7cfed8a6f21e970 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 5a590698f83840385425c2c8a7cfed8a6f21e970 # timeout=10
Commit message: "add container info"
 > git rev-list --no-walk 02c32ffa47404b59435acf6cb72a3651ac2dc64a # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins7511917389623628159.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins5636677063908868472.sh

@bschifferer bschifferer requested a review from rnyak May 10, 2022 10:04
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-298

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #298 of commit e4b135b25326558aaf5185c630fc12463904df7c, no merge conflicts.
Running as SYSTEM
Setting status of e4b135b25326558aaf5185c630fc12463904df7c to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/78/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/298/*:refs/remotes/origin/pr/298/* # timeout=10
 > git rev-parse e4b135b25326558aaf5185c630fc12463904df7c^{commit} # timeout=10
Checking out Revision e4b135b25326558aaf5185c630fc12463904df7c (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f e4b135b25326558aaf5185c630fc12463904df7c # timeout=10
Commit message: "fix naming in hugectr inference"
 > git rev-list --no-walk 5a590698f83840385425c2c8a7cfed8a6f21e970 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins7296125642621738026.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins6130765117554032129.sh

@rnyak rnyak merged commit 9bfa478 into NVIDIA-Merlin:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link notebooks to containers in a way that makes it clear which container a given notebook will run on.
3 participants