Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail the build if tritonserver is missing from inference containers #358

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

benfred
Copy link
Member

@benfred benfred commented Jun 1, 2022

Currently whereis reports success even if the executable isn't found.
Switch the which which will fail the script instead

Currently `whereis` reports success even if the executable isn't found.
Switch the `which` which will fail the script instead
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-358

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #358 of commit e4c63006e09c0f1d6e45036388228ee0f07b44d7, no merge conflicts.
Running as SYSTEM
Setting status of e4c63006e09c0f1d6e45036388228ee0f07b44d7 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/129/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/358/*:refs/remotes/origin/pr/358/* # timeout=10
 > git rev-parse e4c63006e09c0f1d6e45036388228ee0f07b44d7^{commit} # timeout=10
Checking out Revision e4c63006e09c0f1d6e45036388228ee0f07b44d7 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f e4c63006e09c0f1d6e45036388228ee0f07b44d7 # timeout=10
Commit message: "Fail the build if tritonserver is missing from inference containers"
 > git rev-list --no-walk b9ca51dcf80b524ad3af78aae6eef96cc658e449 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins16737029794731738654.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins14398459968055632751.sh

@jperez999 jperez999 merged commit a973b7e into main Jun 2, 2022
@benfred benfred deleted the fail_on_missing_triton branch June 2, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants