Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvt backend back into containers #382

Merged
merged 26 commits into from
Jun 9, 2022

Conversation

jperez999
Copy link
Collaborator

No description provided.

jperez999 added 26 commits May 2, 2022 16:24
@jperez999 jperez999 self-assigned this Jun 9, 2022
@jperez999 jperez999 added the bug Something isn't working label Jun 9, 2022
@jperez999 jperez999 added this to the Merlin 22.06 milestone Jun 9, 2022
@jperez999
Copy link
Collaborator Author

rerun tests

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #382 of commit 4c02606886be6a316f23e1840e83d25d99ebf2f7, no merge conflicts.
Running as SYSTEM
Setting status of 4c02606886be6a316f23e1840e83d25d99ebf2f7 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/142/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/382/*:refs/remotes/origin/pr/382/* # timeout=10
 > git rev-parse 4c02606886be6a316f23e1840e83d25d99ebf2f7^{commit} # timeout=10
Checking out Revision 4c02606886be6a316f23e1840e83d25d99ebf2f7 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 4c02606886be6a316f23e1840e83d25d99ebf2f7 # timeout=10
Commit message: "add nvt back"
 > git rev-list --no-walk 66e4665070798081b8e7ff9ec9aac610885a7b55 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins1602706572009682117.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins10334516833806830678.sh

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-382

@@ -1,7 +1,7 @@
# syntax=docker/dockerfile:1.2
ARG TRITON_VERSION=22.03
ARG TRITON_VERSION=22.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right triton version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not but these files are irrelevant and need to be removed anyway

@jperez999 jperez999 requested a review from benfred June 9, 2022 17:41
@jperez999 jperez999 merged commit f7af5bd into NVIDIA-Merlin:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants