Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support matrix updates for 22.06 #435

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Support matrix updates for 22.06 #435

merged 2 commits into from
Jul 7, 2022

Conversation

nvidia-merlin-bot
Copy link
Contributor

Updates from containers

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-435

@nvidia-merlin-bot
Copy link
Contributor Author

Click to view CI Results
GitHub pull request #435 of commit 21c5de6dd540a84e0dbc868b265dcb5f797431a9, no merge conflicts.
Running as SYSTEM
Setting status of 21c5de6dd540a84e0dbc868b265dcb5f797431a9 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/227/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/435/*:refs/remotes/origin/pr/435/* # timeout=10
 > git rev-parse 21c5de6dd540a84e0dbc868b265dcb5f797431a9^{commit} # timeout=10
Checking out Revision 21c5de6dd540a84e0dbc868b265dcb5f797431a9 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 21c5de6dd540a84e0dbc868b265dcb5f797431a9 # timeout=10
Commit message: "Updates from containers"
 > git rev-list --no-walk 9fbac883e0ba23f656a28adb95b3713984b62641 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins7432615368308382814.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items

tests/unit/test_version.py . [ 50%]
tests/unit/examples/test_building_deploying_multi_stage_RecSys.py . [100%]

======================== 2 passed in 126.04s (0:02:06) =========================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins4231419622664281240.sh

* Remove fictional 22.05 containers
* Add three new containers for 22.06
* Typo fix for #421
@mikemckiernan mikemckiernan self-assigned this Jul 6, 2022
@mikemckiernan mikemckiernan added the documentation Improvements or additions to documentation label Jul 6, 2022
@mikemckiernan mikemckiernan added this to the Merlin 22.06 milestone Jul 6, 2022
@nvidia-merlin-bot
Copy link
Contributor Author

Click to view CI Results
GitHub pull request #435 of commit 9b985b5cd8a2ad65d531e0c0cbbc2d223c6230f0, no merge conflicts.
Running as SYSTEM
Setting status of 9b985b5cd8a2ad65d531e0c0cbbc2d223c6230f0 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/228/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/435/*:refs/remotes/origin/pr/435/* # timeout=10
 > git rev-parse 9b985b5cd8a2ad65d531e0c0cbbc2d223c6230f0^{commit} # timeout=10
Checking out Revision 9b985b5cd8a2ad65d531e0c0cbbc2d223c6230f0 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 9b985b5cd8a2ad65d531e0c0cbbc2d223c6230f0 # timeout=10
Commit message: "Updates to containers for 22.06"
 > git rev-list --no-walk 21c5de6dd540a84e0dbc868b265dcb5f797431a9 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins6515140528310681494.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items

tests/unit/test_version.py . [ 50%]
tests/unit/examples/test_building_deploying_multi_stage_RecSys.py . [100%]

======================== 2 passed in 112.41s (0:01:52) =========================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins11543721516401523240.sh

"merlin.models": "0.4.0",
"merlin.systems": "0.2.0",
"merlin.core": "0.4.0",
"merlin.models": "0.5.0+7.g886cf6de",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised these aren't plain old 0.5.0 and 0.3.0, but I'm not saying anything is wrong here. I tend to believe these probably are the actual versions included in the containers, but maybe there were additional changes after the version tags to get the containers working?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprises in the data are bad. I can't speak to how the versions are determined other than indicating that they come from pip as in python -m pip show "merlin.core". I need to find a more traceable way to get this data. Thanks.

@mikemckiernan mikemckiernan merged commit 442f992 into main Jul 7, 2022
@mikemckiernan mikemckiernan deleted the docs-smx-2206-5 branch July 7, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants