Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyter ENVs in case launching container with normal user #439

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

EmmaQiaoCh
Copy link
Contributor

Set the Jupyter envs to /tmp/.jupyter, then normal user who doesn't have home directory could also start jupyter notebook server directly.

The detail info and discussion could be found in https://gitlab-master.nvidia.com/dl/hugectr/hugectr/-/issues/487
Thanks!

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #439 of commit 7d90685de980c5693cbaba47ae86ae5040da40a5, no merge conflicts.
Running as SYSTEM
Setting status of 7d90685de980c5693cbaba47ae86ae5040da40a5 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/233/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/439/*:refs/remotes/origin/pr/439/* # timeout=10
 > git rev-parse 7d90685de980c5693cbaba47ae86ae5040da40a5^{commit} # timeout=10
Checking out Revision 7d90685de980c5693cbaba47ae86ae5040da40a5 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 7d90685de980c5693cbaba47ae86ae5040da40a5 # timeout=10
Commit message: "Add jupyter ENVs in case launch container with normal user"
 > git rev-list --no-walk c2a14c46544f9f91730dddb0324e50b01b92d222 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins15279652830898046036.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items

tests/unit/test_version.py . [ 50%]
tests/unit/examples/test_building_deploying_multi_stage_RecSys.py . [100%]

========================= 2 passed in 89.29s (0:01:29) =========================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins13873193611958759827.sh

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-439

@karlhigley karlhigley requested review from jperez999 and benfred July 7, 2022 19:31
@jperez999 jperez999 added enhancement New feature or request ci labels Jul 7, 2022
@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #439 of commit 5f12a58b5dca94b7a36862c2b12e1fb2b5fcd19d, no merge conflicts.
Running as SYSTEM
Setting status of 5f12a58b5dca94b7a36862c2b12e1fb2b5fcd19d to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/237/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/439/*:refs/remotes/origin/pr/439/* # timeout=10
 > git rev-parse 5f12a58b5dca94b7a36862c2b12e1fb2b5fcd19d^{commit} # timeout=10
Checking out Revision 5f12a58b5dca94b7a36862c2b12e1fb2b5fcd19d (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 5f12a58b5dca94b7a36862c2b12e1fb2b5fcd19d # timeout=10
Commit message: "Merge branch 'main' into add_jupyter_envs"
 > git rev-list --no-walk fd5ffff662931b2208f077453bd9804d2aa667a1 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins928537160721484593.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items

tests/unit/test_version.py . [ 50%]
tests/unit/examples/test_building_deploying_multi_stage_RecSys.py . [100%]

======================== 2 passed in 143.95s (0:02:23) =========================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins12897460269167387470.sh

@jperez999 jperez999 merged commit d35dde0 into NVIDIA-Merlin:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants