-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add filtering step to the multi-stage recsys building and deployment notebooks #496
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation preview |
Click to view CI ResultsGitHub pull request #496 of commit c68297f2870235ee7d247eab35ed5264579fc194, no merge conflicts. Running as SYSTEM Setting status of c68297f2870235ee7d247eab35ed5264579fc194 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/297/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/496/*:refs/remotes/origin/pr/496/* # timeout=10 > git rev-parse c68297f2870235ee7d247eab35ed5264579fc194^{commit} # timeout=10 Checking out Revision c68297f2870235ee7d247eab35ed5264579fc194 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f c68297f2870235ee7d247eab35ed5264579fc194 # timeout=10 Commit message: "add filtering step" > git rev-list --no-walk 33650ff3be4f27c39d99f0e06a983d521bd7fcff # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins8071722894646148979.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 2 items |
Click to view CI ResultsGitHub pull request #496 of commit 75b4ee4b4ab80a5a032a3eaaf88b71ea93ee21b4, no merge conflicts. Running as SYSTEM Setting status of 75b4ee4b4ab80a5a032a3eaaf88b71ea93ee21b4 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/298/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/496/*:refs/remotes/origin/pr/496/* # timeout=10 > git rev-parse 75b4ee4b4ab80a5a032a3eaaf88b71ea93ee21b4^{commit} # timeout=10 Checking out Revision 75b4ee4b4ab80a5a032a3eaaf88b71ea93ee21b4 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 75b4ee4b4ab80a5a032a3eaaf88b71ea93ee21b4 # timeout=10 Commit message: "fix unrolled feats" > git rev-list --no-walk c68297f2870235ee7d247eab35ed5264579fc194 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins15538796526900657261.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 2 items |
Click to view CI ResultsGitHub pull request #496 of commit 4c808d607d4e78a20aa4e43138a6c87eafe0274d, no merge conflicts. Running as SYSTEM Setting status of 4c808d607d4e78a20aa4e43138a6c87eafe0274d to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/305/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/496/*:refs/remotes/origin/pr/496/* # timeout=10 > git rev-parse 4c808d607d4e78a20aa4e43138a6c87eafe0274d^{commit} # timeout=10 Checking out Revision 4c808d607d4e78a20aa4e43138a6c87eafe0274d (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 4c808d607d4e78a20aa4e43138a6c87eafe0274d # timeout=10 Commit message: "Merge branch 'main' into poc_with_filtering" > git rev-list --no-walk 24ec50b91c077343ae97b54287bf4bb06584db7c # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins16905772863289261204.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Click to view CI ResultsGitHub pull request #496 of commit 550aeb40387b2e4ff05da58b0905360fcb34dd70, no merge conflicts. Running as SYSTEM Setting status of 550aeb40387b2e4ff05da58b0905360fcb34dd70 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/317/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/496/*:refs/remotes/origin/pr/496/* # timeout=10 > git rev-parse 550aeb40387b2e4ff05da58b0905360fcb34dd70^{commit} # timeout=10 Checking out Revision 550aeb40387b2e4ff05da58b0905360fcb34dd70 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 550aeb40387b2e4ff05da58b0905360fcb34dd70 # timeout=10 Commit message: "Merge branch 'main' into poc_with_filtering" > git rev-list --no-walk 32fc61dbf99f58fc4d0d65fb5b65a7291b2f757a # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins2973867071528776025.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
"source": [ | ||
"# Filter out anything that was in the user's current session\n", | ||
"filtering = retrieval[\"candidate_ids\"] >> FilterCandidates(\n", | ||
" filter_out=user_features[\"item_id_seen\"]\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try making this filter_out=user_features["item_id_seen_1"]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still doesnt work unfortunately.
Click to view CI ResultsGitHub pull request #496 of commit 9f4c0f6634920117dd7b044e481575b49fb55d75, no merge conflicts. Running as SYSTEM Setting status of 9f4c0f6634920117dd7b044e481575b49fb55d75 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/323/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/496/*:refs/remotes/origin/pr/496/* # timeout=10 > git rev-parse 9f4c0f6634920117dd7b044e481575b49fb55d75^{commit} # timeout=10 Checking out Revision 9f4c0f6634920117dd7b044e481575b49fb55d75 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 9f4c0f6634920117dd7b044e481575b49fb55d75 # timeout=10 Commit message: "Merge branch 'main' into poc_with_filtering" > git rev-list --no-walk 3830d193ebeee1c9be697465a1d160b000e17a58 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins13759369557583878690.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Click to view CI ResultsGitHub pull request #496 of commit 5bbe4aa591d1c1e4eaa00ccb9ea025167586b66c, no merge conflicts. Running as SYSTEM Setting status of 5bbe4aa591d1c1e4eaa00ccb9ea025167586b66c to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/327/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/496/*:refs/remotes/origin/pr/496/* # timeout=10 > git rev-parse 5bbe4aa591d1c1e4eaa00ccb9ea025167586b66c^{commit} # timeout=10 Checking out Revision 5bbe4aa591d1c1e4eaa00ccb9ea025167586b66c (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 5bbe4aa591d1c1e4eaa00ccb9ea025167586b66c # timeout=10 Commit message: "Merge branch 'main' into poc_with_filtering" > git rev-list --no-walk 792f14a5f1b0ef07690ba865698bd1a675dab632 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins13636343195833768746.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Click to view CI ResultsGitHub pull request #496 of commit 8a5d7799725b1b558b0e3b06a2219b2deb2ad56f, no merge conflicts. Running as SYSTEM Setting status of 8a5d7799725b1b558b0e3b06a2219b2deb2ad56f to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/332/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/496/*:refs/remotes/origin/pr/496/* # timeout=10 > git rev-parse 8a5d7799725b1b558b0e3b06a2219b2deb2ad56f^{commit} # timeout=10 Checking out Revision 8a5d7799725b1b558b0e3b06a2219b2deb2ad56f (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 8a5d7799725b1b558b0e3b06a2219b2deb2ad56f # timeout=10 Commit message: "Merge branch 'main' into poc_with_filtering" > git rev-list --no-walk 829a495f8ece5ecf14b891fdfed41a861a3d6433 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins2944827041103249446.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
closing for now since this is waiting for NVIDIA-Merlin/systems#173 |
Currently PoC notebook does not have filtering step this PR tries to add this with a hacky workaround. However I get an error (see below) when I try to export the ensemble graph.