Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get TF version from Python and not Pip #498

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

mikemckiernan
Copy link
Member

@mikemckiernan mikemckiernan commented Aug 4, 2022

The extractor code attempted to use the output from pip to determine the TensorFlow version. That approach is incorrect and the version is available by importing the library and getting the value from __version__.

@mikemckiernan mikemckiernan self-assigned this Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-498

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #498 of commit 54d4f77d4ab3c4f100d96c617f5c3a17546ad8a7, no merge conflicts.
Running as SYSTEM
Setting status of 54d4f77d4ab3c4f100d96c617f5c3a17546ad8a7 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/307/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/498/*:refs/remotes/origin/pr/498/* # timeout=10
 > git rev-parse 54d4f77d4ab3c4f100d96c617f5c3a17546ad8a7^{commit} # timeout=10
Checking out Revision 54d4f77d4ab3c4f100d96c617f5c3a17546ad8a7 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 54d4f77d4ab3c4f100d96c617f5c3a17546ad8a7 # timeout=10
Commit message: "Get TF version from Python and not Pip"
 > git rev-list --no-walk 9ed7bc1654d70b14ca4ba3a45a2db3056c7b52c0 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins12700584944051836136.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 3 items

tests/unit/test_version.py . [ 33%]
tests/unit/examples/test_building_deploying_multi_stage_RecSys.py . [ 66%]
tests/unit/examples/test_scaling_criteo_merlin_models.py . [100%]

======================== 3 passed in 239.00s (0:03:58) =========================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins11379062559564750684.sh

@mikemckiernan mikemckiernan added the documentation Improvements or additions to documentation label Aug 4, 2022
@mikemckiernan mikemckiernan requested a review from benfred August 4, 2022 21:08
@benfred benfred merged commit cf20dc8 into NVIDIA-Merlin:main Aug 4, 2022
@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #498 of commit 13245f7ab276e4becb93e508dace9e1f863ef59d, no merge conflicts.
Running as SYSTEM
Setting status of 13245f7ab276e4becb93e508dace9e1f863ef59d to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/308/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/498/*:refs/remotes/origin/pr/498/* # timeout=10
 > git rev-parse 13245f7ab276e4becb93e508dace9e1f863ef59d^{commit} # timeout=10
Checking out Revision 13245f7ab276e4becb93e508dace9e1f863ef59d (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 13245f7ab276e4becb93e508dace9e1f863ef59d # timeout=10
Commit message: "Merge branch 'main' into fix-tf-version"
 > git rev-list --no-walk 54d4f77d4ab3c4f100d96c617f5c3a17546ad8a7 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins1448785486170032648.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 3 items

tests/unit/test_version.py . [ 33%]
tests/unit/examples/test_building_deploying_multi_stage_RecSys.py . [ 66%]
tests/unit/examples/test_scaling_criteo_merlin_models.py . [100%]

======================== 3 passed in 243.78s (0:04:03) =========================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins3585633899403585579.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants