-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install CMake in Merlin base image (instead of copying from build) #524
Conversation
Since the CMake install is a bit more involved than just copying the executable, let's just install it in the base container directly.
Documentation preview |
Click to view CI ResultsGitHub pull request #524 of commit df88d4b685158dfb8ab622772ebb81c61eb770e2, no merge conflicts. Running as SYSTEM Setting status of df88d4b685158dfb8ab622772ebb81c61eb770e2 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/333/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/524/*:refs/remotes/origin/pr/524/* # timeout=10 > git rev-parse df88d4b685158dfb8ab622772ebb81c61eb770e2^{commit} # timeout=10 Checking out Revision df88d4b685158dfb8ab622772ebb81c61eb770e2 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f df88d4b685158dfb8ab622772ebb81c61eb770e2 # timeout=10 Commit message: "Install CMake in Merlin base image (instead of copying from build)" > git rev-list --no-walk 8a5d7799725b1b558b0e3b06a2219b2deb2ad56f # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins3321469593476589153.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Click to view CI ResultsGitHub pull request #524 of commit a1c95f262485c8f5d7f6e07d42b1a678d011f7bf, no merge conflicts. Running as SYSTEM Setting status of a1c95f262485c8f5d7f6e07d42b1a678d011f7bf to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/339/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/524/*:refs/remotes/origin/pr/524/* # timeout=10 > git rev-parse a1c95f262485c8f5d7f6e07d42b1a678d011f7bf^{commit} # timeout=10 Checking out Revision a1c95f262485c8f5d7f6e07d42b1a678d011f7bf (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f a1c95f262485c8f5d7f6e07d42b1a678d011f7bf # timeout=10 Commit message: "Merge branch 'main' into fix/cmake-install-v2" > git rev-list --no-walk b7c1dc3c34920a5fa4c512d129c0f8c7097ce4d1 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins3151402713106632480.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
rerun tests |
Click to view CI ResultsGitHub pull request #524 of commit a1c95f262485c8f5d7f6e07d42b1a678d011f7bf, no merge conflicts. Running as SYSTEM Setting status of a1c95f262485c8f5d7f6e07d42b1a678d011f7bf to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/340/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/524/*:refs/remotes/origin/pr/524/* # timeout=10 > git rev-parse a1c95f262485c8f5d7f6e07d42b1a678d011f7bf^{commit} # timeout=10 Checking out Revision a1c95f262485c8f5d7f6e07d42b1a678d011f7bf (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f a1c95f262485c8f5d7f6e07d42b1a678d011f7bf # timeout=10 Commit message: "Merge branch 'main' into fix/cmake-install-v2" > git rev-list --no-walk a1c95f262485c8f5d7f6e07d42b1a678d011f7bf # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins16143319096547220262.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
rerun tests |
Click to view CI ResultsGitHub pull request #524 of commit a1c95f262485c8f5d7f6e07d42b1a678d011f7bf, no merge conflicts. Running as SYSTEM Setting status of a1c95f262485c8f5d7f6e07d42b1a678d011f7bf to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/341/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/524/*:refs/remotes/origin/pr/524/* # timeout=10 > git rev-parse a1c95f262485c8f5d7f6e07d42b1a678d011f7bf^{commit} # timeout=10 Checking out Revision a1c95f262485c8f5d7f6e07d42b1a678d011f7bf (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f a1c95f262485c8f5d7f6e07d42b1a678d011f7bf # timeout=10 Commit message: "Merge branch 'main' into fix/cmake-install-v2" > git rev-list --no-walk a1c95f262485c8f5d7f6e07d42b1a678d011f7bf # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins1401953661412466205.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Click to view CI ResultsGitHub pull request #524 of commit eb0789cb30033872c2d0aa82b722fc6e94b24da8, no merge conflicts. Running as SYSTEM Setting status of eb0789cb30033872c2d0aa82b722fc6e94b24da8 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/342/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/524/*:refs/remotes/origin/pr/524/* # timeout=10 > git rev-parse eb0789cb30033872c2d0aa82b722fc6e94b24da8^{commit} # timeout=10 Checking out Revision eb0789cb30033872c2d0aa82b722fc6e94b24da8 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f eb0789cb30033872c2d0aa82b722fc6e94b24da8 # timeout=10 Commit message: "Avoid copying CMake libraries over the top of install" > git rev-list --no-walk a1c95f262485c8f5d7f6e07d42b1a678d011f7bf # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins7322710968896341975.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Since the CMake install is a bit more involved than just copying the executable, let's just install it in the base container directly.