Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies of hugectr & install hps tf plugin to merlin-tf #549

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

EmmaQiaoCh
Copy link
Contributor

  • Remove dependencies of hugectr
  • Install hps tf plugin to merlin-tf

* Remove dependencies of hugectr
* Install hps tf plugin to merlin-tf
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-549

@benfred benfred added the chore Infrastructure update label Aug 16, 2022
@viswa-nvidia viswa-nvidia added this to the Merlin 22.08 milestone Aug 16, 2022
@benfred
Copy link
Member

benfred commented Aug 17, 2022

rerun tests

@benfred
Copy link
Member

benfred commented Aug 17, 2022

Note this will require https://github.com/NVIDIA-Merlin/HugeCTR/releases/tag/v3.9 to build succesfully

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #549 of commit 37f243780bd7bb8048ce1ad6aaec3e34bc6dff26, no merge conflicts.
Running as SYSTEM
Setting status of 37f243780bd7bb8048ce1ad6aaec3e34bc6dff26 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/353/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/549/*:refs/remotes/origin/pr/549/* # timeout=10
 > git rev-parse 37f243780bd7bb8048ce1ad6aaec3e34bc6dff26^{commit} # timeout=10
Checking out Revision 37f243780bd7bb8048ce1ad6aaec3e34bc6dff26 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 37f243780bd7bb8048ce1ad6aaec3e34bc6dff26 # timeout=10
Commit message: "Remove dependencies of hugectr"
 > git rev-list --no-walk 4a74b60b4c539996cb8950b76243005ee48a85e3 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins16432455287868510063.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 3 items

tests/unit/test_version.py . [ 33%]
tests/unit/examples/test_building_deploying_multi_stage_RecSys.py s [ 66%]
tests/unit/examples/test_scaling_criteo_merlin_models.py . [100%]

=================== 2 passed, 1 skipped in 108.33s (0:01:48) ===================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins1715937608349329827.sh

@benfred benfred merged commit b959521 into NVIDIA-Merlin:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Infrastructure update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants