-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit scaling criteo inference serving #559
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Click to view CI ResultsGitHub pull request #559 of commit 18f8854e9c7149f93bd7447ee1150020c1faf000, no merge conflicts. Running as SYSTEM Setting status of 18f8854e9c7149f93bd7447ee1150020c1faf000 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/368/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/559/*:refs/remotes/origin/pr/559/* # timeout=10 > git rev-parse 18f8854e9c7149f93bd7447ee1150020c1faf000^{commit} # timeout=10 Checking out Revision 18f8854e9c7149f93bd7447ee1150020c1faf000 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 18f8854e9c7149f93bd7447ee1150020c1faf000 # timeout=10 Commit message: "fix unit test for scaling criteo" > git rev-list --no-walk d8ab03429179e7dd1467123a0334d9dbf9875576 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins9875516084636874203.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Documentation preview |
rerun tests |
Click to view CI ResultsGitHub pull request #559 of commit 18f8854e9c7149f93bd7447ee1150020c1faf000, no merge conflicts. Running as SYSTEM Setting status of 18f8854e9c7149f93bd7447ee1150020c1faf000 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/369/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/559/*:refs/remotes/origin/pr/559/* # timeout=10 > git rev-parse 18f8854e9c7149f93bd7447ee1150020c1faf000^{commit} # timeout=10 Checking out Revision 18f8854e9c7149f93bd7447ee1150020c1faf000 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 18f8854e9c7149f93bd7447ee1150020c1faf000 # timeout=10 Commit message: "fix unit test for scaling criteo" > git rev-list --no-walk 18f8854e9c7149f93bd7447ee1150020c1faf000 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins7113214151575744866.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Click to view CI ResultsGitHub pull request #559 of commit 3832ea55a7cc44dce1f693d5e718ddc49a12f1a6, no merge conflicts. Running as SYSTEM Setting status of 3832ea55a7cc44dce1f693d5e718ddc49a12f1a6 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/370/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/559/*:refs/remotes/origin/pr/559/* # timeout=10 > git rev-parse 3832ea55a7cc44dce1f693d5e718ddc49a12f1a6^{commit} # timeout=10 Checking out Revision 3832ea55a7cc44dce1f693d5e718ddc49a12f1a6 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 3832ea55a7cc44dce1f693d5e718ddc49a12f1a6 # timeout=10 Commit message: "add back model import" > git rev-list --no-walk 18f8854e9c7149f93bd7447ee1150020c1faf000 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins3194441305650325862.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Newer versions of triton do not allow startup from within the context of a notebook, that is within the context of testbooks. This fix is to remedy those issues.