Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dask/distributed package versions after other installs in CI image #841

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Pin dask/distributed package versions after other installs in CI image #841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ci/dockerfile.ci
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ FROM ${BASE_IMAGE}
COPY --chown=1000:1000 --from=triton /opt/tritonserver/backends/tensorflow2 backends/tensorflow2/
COPY --chown=1000:1000 --from=triton /opt/tritonserver/backends/pytorch backends/pytorch/

RUN pip install dask==2022.7.1 distributed==2022.7.1
RUN pip install tensorflow-gpu==2.9.2
RUN pip install torch --extra-index-url https://download.pytorch.org/whl/cu117
RUN pip install torchmetrics==0.10.0 matplotlib
Expand All @@ -21,6 +20,10 @@ RUN pip install astroid==2.5.6 'feast<0.20' sklearn
RUN echo 'import sphinx.domains' >> /usr/local/lib/python3.8/dist-packages/sphinx/__init__.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your downgrade of dask happens in feast<0.20. It has an anchored requirement for dask 2022.1 So yeah adding dask reinstall at the end should do the trick.

RUN HOROVOD_GPU_OPERATIONS=NCCL python -m pip install --no-cache-dir horovod && horovodrun --check-build

# Pin dask/distributed package versions after other installs
# to make sure we have the right ones
RUN pip install dask==2022.7.1 distributed==2022.7.1

RUN pip install tox

# Update the Merlin repos (to avoid needed to rebuild underlying images to get updates)
Expand Down