Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64 support in dockerfile.merlin #846

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Conversation

jlinford
Copy link
Contributor

Resolves #834 to add support for Arm64 in the Merlin base image. Additional changes are needed in other dockerfiles to broadly enable Arm64 support, but this is a start.

@jlinford
Copy link
Contributor Author

I've successfully built on both arm64 and amd64 via docker build - < docker/dockerfile.merlin.

@karlhigley karlhigley added chore Infrastructure update ci labels Feb 28, 2023
@karlhigley karlhigley added this to the Merlin 23.03 milestone Feb 28, 2023
@karlhigley karlhigley requested a review from edknv February 28, 2023 21:00
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-846

@karlhigley
Copy link
Contributor

This LGTM but I want to get eyes on it from the people working on our container releases before pushing the big green button 😄

docker/dockerfile.merlin Show resolved Hide resolved
docker/dockerfile.merlin Show resolved Hide resolved
docker/dockerfile.merlin Show resolved Hide resolved
docker/dockerfile.merlin Show resolved Hide resolved
@jlinford jlinford requested review from jperez999 and removed request for oliverholworthy and edknv February 28, 2023 23:40
@jperez999
Copy link
Collaborator

@jlinford does the build command have to change for all builds? Like to build the non-arm docker image do I need to use docker build - < docker/dockerfile.merlin or does docker build -t <tag name> -f docker/dockerfile.merlin . ? If so, because we are in release right now I am going to hold off until that is complete before adding this because we will need to change CI commands in the container build process.

@jlinford
Copy link
Contributor Author

jlinford commented Mar 1, 2023

The build command should not change, either on arm64 or x86_64. On arm64, it should be possible to use the exact same build command you currently use on x86_64, and get an arm64 image as a result. If that doesn't work, I'd consider it a bug and would want to fix it.

@jlinford
Copy link
Contributor Author

jlinford commented Mar 1, 2023

Apologies, I think I accidentally removed @oliverholworthy and @edknv from the reviewers, but somehow can't add them back. Happy to have their review!

@jperez999
Copy link
Collaborator

jperez999 commented Mar 1, 2023

I approved... but we will wait to merge. Sorry I should have done that when we resolved the comments.

@karlhigley karlhigley merged commit b280cd2 into NVIDIA-Merlin:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Infrastructure update ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] ARM support
3 participants