-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm64 support in dockerfile.merlin #846
Conversation
I've successfully built on both arm64 and amd64 via |
Documentation preview |
This LGTM but I want to get eyes on it from the people working on our container releases before pushing the big green button 😄 |
@jlinford does the build command have to change for all builds? Like to build the non-arm docker image do I need to use |
The build command should not change, either on arm64 or x86_64. On arm64, it should be possible to use the exact same build command you currently use on x86_64, and get an arm64 image as a result. If that doesn't work, I'd consider it a bug and would want to fix it. |
Apologies, I think I accidentally removed @oliverholworthy and @edknv from the reviewers, but somehow can't add them back. Happy to have their review! |
I approved... but we will wait to merge. Sorry I should have done that when we resolved the comments. |
Resolves #834 to add support for Arm64 in the Merlin base image. Additional changes are needed in other dockerfiles to broadly enable Arm64 support, but this is a start.