Fix libnvinfer conflict #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EmmaQiaoCh
commented
Mar 14, 2023
EmmaQiaoCh
commented
- remove the specified version of libnvinfer
- copy libcupti.so.12 instead of libcupti.so.11.8 which is not in upstream container
- update TFDE_VER=v0.3 to fix some build error
Documentation preview |
|
Running this in pre-release environment. Will report back if any issues... otherwise I will approve. |
jperez999
reviewed
Mar 14, 2023
| @@ -198,15 +198,15 @@ RUN apt update -y --fix-missing && \ | |||
| # Required to build Protocol Buffers. | |||
| autoconf automake libtool \ | |||
| # Required to build Hadoop. | |||
| default-jdk maven pkg-config \ | |||
There was a problem hiding this comment.
Love that we can remove this.
|
The test failure here is unrelated and we have an open PR to fix it. Will merge that one and re-run this. |
|
@jperez999 @karlhigley Thanks for your info, but we just hit regression errors when testing SOK and hps_trt on the new TF, so please hold on this PR although your tests passed. We may need more changes. |
karlhigley
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.