update version of cupy to be 12.0.0 minimum #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
edknv
reviewed
Apr 7, 2023
Comment on lines
-107
to
+109
| pip install cupy-cuda115 -f https://pip.cupy.dev/aarch64/ ; \ | ||
| pip install cupy-cuda11x -f https://pip.cupy.dev/aarch64/ ; \ | ||
| else \ | ||
| pip install cupy-cuda117 ; \ | ||
| pip install cupy-cuda11x ; \ |
There was a problem hiding this comment.
Maybe I'm missing something but shouldn't these be cupy-cuda12x not cuda11x if we want the minimum version to be 12.0?
There was a problem hiding this comment.
It's confusing, because CUDA and CuPy are both currently at version 12. We need CuPy version 12.0.0 or greater, which is the latest version available for CUDA 11.
karlhigley
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of cupy on the containers to make sure it is 12.0 or later. This is important because in v12.0+ dlpack is implemented correctly. This is leveraged by tensortable.