Quick-start for Ranking: Fix bug when saving model trained with single task and moved util classes to Models #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielspmoreira
added
bug
Documentation preview |
…util classes to Merlin Models
gabrielspmoreira
force-pushed
the
tf/qq_extract_logloss_callbacks
branch
from
ef15aba to
a64b9d6
Compare
rnyak
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that was occurring when trying to save a model trained for single-task learning.
It also extracts the following util classes from the Quick-Start scrips, which are added in #1085 to Merlin Models:
LogLossMetricWandbLoggerExamplesPerSecondCallbackImportant: This PR can only be merged after #1085 is merged.