Remove poetry config #1673
Remove poetry config #1673
Conversation
We added poetry config to allow nspect to scan our dependencies. This poetry config has caused issues before with customers, with dependencies not being up to date - since our main dependencies are specified in the requirements.txt files. Also the version number included in the poetry config is months out of date, and still shows a pre 1.0 version. Since we are now going a different route for nspect scanning, remove this config.
Click to view CI ResultsGitHub pull request #1673 of commit 4ee2bbceb941fb9de161e2e759b7ee65d9cda00c, no merge conflicts.
Running as SYSTEM
Setting status of 4ee2bbceb941fb9de161e2e759b7ee65d9cda00c to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4687/ and message: 'Build started for merge commit.'
Using context: Jenkins Unit Test Run
Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests
using credential nvidia-merlin-bot
Cloning the remote Git repository
Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git
> git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
> git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1673/*:refs/remotes/origin/pr/1673/* # timeout=10
> git rev-parse 4ee2bbceb941fb9de161e2e759b7ee65d9cda00c^{commit} # timeout=10
Checking out Revision 4ee2bbceb941fb9de161e2e759b7ee65d9cda00c (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 4ee2bbceb941fb9de161e2e759b7ee65d9cda00c # timeout=10
Commit message: "Remove poetry config"
> git rev-list --no-walk f9064e0eb17c6138afdd7b47b8582eff9557cd71 # timeout=10
First time build. Skipping changelog.
[nvtabular_tests] $ /bin/bash /tmp/jenkins10086148114171886437.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1429 items / 1 skipped
|
Documentation preview |
Click to view CI ResultsGitHub pull request #1673 of commit 72f75f4094a52a60eb28abaee0e3e23385da04a4, no merge conflicts.
Running as SYSTEM
Setting status of 72f75f4094a52a60eb28abaee0e3e23385da04a4 to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4692/ and message: 'Build started for merge commit.'
Using context: Jenkins Unit Test Run
Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests
using credential nvidia-merlin-bot
Cloning the remote Git repository
Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git
> git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
> git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1673/*:refs/remotes/origin/pr/1673/* # timeout=10
> git rev-parse 72f75f4094a52a60eb28abaee0e3e23385da04a4^{commit} # timeout=10
Checking out Revision 72f75f4094a52a60eb28abaee0e3e23385da04a4 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 72f75f4094a52a60eb28abaee0e3e23385da04a4 # timeout=10
Commit message: "Merge branch 'main' into remove_poetry"
> git rev-list --no-walk e51933bf3598c098806a5e6c7140554596dd194e # timeout=10
First time build. Skipping changelog.
[nvtabular_tests] $ /bin/bash /tmp/jenkins17871129425030082359.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1429 items / 1 skipped
|
We added poetry config to allow nspect to scan our dependencies. This poetry config has caused issues before with customers, with dependencies not being up to date - since our main dependencies are specified in the requirements.txt files. Also the version number included in the poetry config is months out of date, and still shows a pre 1.0 version. Since we are now going a different route for nspect scanning, remove this config.
We added poetry config to allow nspect to scan our dependencies.
This poetry config has caused issues before with customers, with dependencies not being up to date - since our main dependencies are specified in the requirements.txt files. Also the version number included in the poetry config is months out of date, and still shows a pre 1.0 version.
Since we are now going a different route for nspect scanning, remove this config.