-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Merlin DAG executors from core in integration tests #1677
Conversation
Click to view CI ResultsGitHub pull request #1677 of commit af531af74b042dc2a612d051b00fc211db66dbe9, no merge conflicts. Running as SYSTEM Setting status of af531af74b042dc2a612d051b00fc211db66dbe9 to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4693/ and message: 'Build started for merge commit.' Using context: Jenkins Unit Test Run Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests using credential nvidia-merlin-bot Cloning the remote Git repository Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git > git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git > git --version # timeout=10 using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1677/*:refs/remotes/origin/pr/1677/* # timeout=10 > git rev-parse af531af74b042dc2a612d051b00fc211db66dbe9^{commit} # timeout=10 Checking out Revision af531af74b042dc2a612d051b00fc211db66dbe9 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f af531af74b042dc2a612d051b00fc211db66dbe9 # timeout=10 Commit message: "use the merlin dag executors in core instead of nvt in integration tests" > git rev-list --no-walk 72f75f4094a52a60eb28abaee0e3e23385da04a4 # timeout=10 [nvtabular_tests] $ /bin/bash /tmp/jenkins16683198853816059212.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 1429 items / 1 skipped |
Documentation preview |
* skip download step, that is not allowed in CI * use the merlin dag executors in core instead of nvt in integration tests
Integration tests are failing because the integration tests were not updated to use the merlin core executors. This fixes those issues.