Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cibuildwheel to build binary distributions for PyPI #1754

Merged
merged 5 commits into from
Jan 26, 2023
Merged

Use cibuildwheel to build binary distributions for PyPI #1754

merged 5 commits into from
Jan 26, 2023

Conversation

karlhigley
Copy link
Contributor

No description provided.

@karlhigley karlhigley added this to the Merlin 23.02 milestone Jan 25, 2023
@karlhigley karlhigley requested a review from jperez999 January 25, 2023 16:44
@karlhigley karlhigley self-assigned this Jan 25, 2023
@karlhigley
Copy link
Contributor Author

It doesn't look like the CPU CI action ran after these changes, which seems...bad.

@karlhigley
Copy link
Contributor Author

karlhigley commented Jan 25, 2023 •
edited
Loading

@jperez999 It looks like the GPU tests are "passing" instantly because they can't find conda on the GHA runner image. Any idea why that might be happening? Could this be a result of renaming the action and therefore having it run in the wrong place?

@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/NVTabular/review/pr-1754

@karlhigley
Copy link
Contributor Author

With cibuildwheel and the current config, the dist folder ends up looking like this, with a variety of Linux wheels (but no Mac or Windows wheels):
gnome-shell-screenshot-kmoiu

@karlhigley karlhigley merged commit 1212e6e into NVIDIA-Merlin:main Jan 26, 2023
oliverholworthy pushed a commit that referenced this pull request Feb 3, 2023
@karlhigley @oliverholworthy
Use cibuildwheel to build binary distributions for PyPI (#1754)
1347885 
* Use `cibuildwheel` to build binary distributions for PyPI

* Fix env variable formatting for `cibuildwheel` action

* Split running CPU tests and building packages into two separate actions

* Rename the CPU and GPU test actions (for clarity)

* Stop building packages on every PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jperez999 jperez999 jperez999 approved these changes

Assignees

@karlhigley karlhigley

Labels
chore ci
Projects
None yet
Milestone
Merlin 23.02
Development

Successfully merging this pull request may close these issues.
2 participants
@karlhigley @jperez999