Skip to content

Commit

Permalink
Remove property from columns attribute on Transformable protocol
Browse files Browse the repository at this point in the history
When a property is declared on a protocol. When used with an
isinstance check this results in the property being called, which can
have unintended side-effects and impact on performance.
  • Loading branch information
oliverholworthy committed Nov 10, 2022
1 parent 6eeceb9 commit b944df8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion merlin/core/protocols.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ class Transformable(DictLike, Protocol):
base to do without them.
"""

@property
def columns(self):
...

Expand Down

0 comments on commit b944df8

Please sign in to comment.