Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the schema to the output of the .repartition() method #192

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

sararb
Copy link
Contributor

@sararb sararb commented Dec 21, 2022

  • For multi-gpu training support in transformers4rec, we are using .repartition() to split the dataset across the number of available GPUs (i.e. global_size) equally. (in this line).
  • The multi-gpu script is broken because the repartition method returns a new Dataset object without copying the original dataset schema (where we set properties such as is_ragged=False and value_count to ensure the dataloader returns dense tensors instead of a tuple representation).
  • This PR proposes a quick-fix where the original schema is passed to the new Dataset object returned by dataset.repartition()

@sararb sararb added bug Something isn't working P0 labels Dec 21, 2022
@sararb sararb requested a review from edknv December 21, 2022 15:08
@sararb sararb self-assigned this Dec 21, 2022
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/core/review/pr-192

@sararb sararb changed the title Add the schema to the output of the . repartition() method Add the schema to the output of the .repartition() method Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants