-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dask
, distributed
, fsspec
versions
#201
Conversation
This version bump doesn't actually seem to work 😅 |
dask
, distributed
, fsspec
versions to >=2022.7.0
dask
, distributed
, fsspec
versions to ==2022.7.1
@jperez999 Seeing a bunch of errors like this in the Systems tests:
Seems like maybe there's a chunk of code for either Core or NVT somewhere that didn't get pushed. Any idea if you have something stashed somewhere? EDIT: The relevant method is right here in |
@karlhigley I think the issue is that we're (edit: NOT) installing the dev version of NVTabular, and instead it's picking up the latest published version in pypi which doesn't have the |
requirements.txt
Outdated
@@ -1,11 +1,11 @@ | |||
dask>=2022.3.0 | |||
distributed>=2022.3.0 | |||
dask==2022.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is going to turn into the package install_requires
. having a range (minimum) may be preferable to the explicit pinned version here to improve the chances of finding compatibile versions of packages in a project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had trouble with that because it ended up picking newer versions than we're actually compatible with, but I'm not sure where the cut-off is.
222d0d7
to
a3474a1
Compare
dask
, distributed
, fsspec
versions to ==2022.7.1
dask
, distributed
, fsspec
versions
`fsspec 2022.8.1` got yanked and replaced with `2022.8.2`, so these are equivalent versions although the numbers are slightly different.
a3474a1
to
46596e7
Compare
There's a breaking change in distributed 2022.11.1 that our version of `dask_cuda` isn't compatible with yet.
No description provided.