Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dask, distributed, fsspec versions #201

Merged
merged 6 commits into from
Mar 22, 2023

Conversation

karlhigley
Copy link
Contributor

No description provided.

@karlhigley karlhigley added chore Maintenance for the repository build labels Jan 25, 2023
@karlhigley karlhigley added this to the Merlin 23.02 milestone Jan 25, 2023
@karlhigley karlhigley requested a review from jperez999 January 25, 2023 16:28
@karlhigley karlhigley self-assigned this Jan 25, 2023
@karlhigley
Copy link
Contributor Author

This version bump doesn't actually seem to work 😅

@karlhigley karlhigley changed the title Bump dask, distributed, fsspec versions to >=2022.7.0 Bump dask, distributed, fsspec versions to ==2022.7.1 Feb 2, 2023
@karlhigley
Copy link
Contributor Author

karlhigley commented Feb 2, 2023

@jperez999 Seeing a bunch of errors like this in the Systems tests:

AttributeError: 'Workflow' object has no attribute '_transform_df'

Seems like maybe there's a chunk of code for either Core or NVT somewhere that didn't get pushed. Any idea if you have something stashed somewhere?

EDIT: The relevant method is right here in Workflow on NVT's main branch, so I'm very confused.

@oliverholworthy
Copy link
Member

oliverholworthy commented Feb 2, 2023

@jperez999 Seeing a bunch of errors like this in the Systems tests:

AttributeError: 'Workflow' object has no attribute '_transform_df'

Seems like maybe there's a chunk of code for either Core or NVT somewhere that didn't get pushed. Any idea if you have something stashed somewhere?

EDIT: The relevant method is right here in Workflow on NVT's main branch, so I'm very confused.

@karlhigley I think the issue is that we're (edit: NOT) installing the dev version of NVTabular, and instead it's picking up the latest published version in pypi which doesn't have the _transform_df yet. We may need to add some lines to the tox config to install NVTabular for each of the sub-project tests?

requirements.txt Outdated
@@ -1,11 +1,11 @@
dask>=2022.3.0
distributed>=2022.3.0
dask==2022.7.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is going to turn into the package install_requires. having a range (minimum) may be preferable to the explicit pinned version here to improve the chances of finding compatibile versions of packages in a project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had trouble with that because it ended up picking newer versions than we're actually compatible with, but I'm not sure where the cut-off is.

@karlhigley karlhigley changed the title Bump dask, distributed, fsspec versions to ==2022.7.1 Bump dask, distributed, fsspec versions Feb 22, 2023
`fsspec 2022.8.1` got yanked and replaced with `2022.8.2`, so these are equivalent versions although the numbers are slightly different.
@karlhigley karlhigley modified the milestones: Merlin 23.03, Merlin 23.04 Mar 22, 2023
@karlhigley karlhigley merged commit c070a47 into NVIDIA-Merlin:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build chore Maintenance for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants