Reduce the overhead of using LocalExecutor (esp. dtype validation)
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We usually want this in order to catch places where operators are producing data that doesn't match their output schemas, but it produces way too much performance overhead when run on every batch in the dataloaders.
We can speed up both code paths here by assuming we're on the happy path and catching errors when they happen instead of calling `hash` first to check.
We don't need the extra logic from `Dtype.with_shape` in this case, since we already know that `Shape()` is a valid shape.
jperez999
approved these changes
Feb 13, 2023
oliverholworthy
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.