Add pynvml dependency #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct name of pynvml package
oliverholworthy
force-pushed
the
pynvml-dependency
branch
from
1bc04d9 to
6fd5f52
Compare
jperez999
approved these changes
Mar 8, 2023
oliverholworthy
added a commit
that referenced
this pull request
Mar 10, 2023
* Add pynvml dependency Correct name of pynvml package * Add comment to requirements.txt about pynvml version * Remove whitespace from requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pynvml dependency. pynvml is not required by any of the dependencies. However, we require this package for checking for GPU compatibility and some a function to get device memory used by
merlin.io.Dataset.Restricting pynvml to <11.5 due to an incompatibility between
distributed<2023.2.1andpynvml==11.5.0. If we at some point increase the min version of dask/distributed to 2023.2.1 then we can change the pynvml version restrictionFixes NVIDIA-Merlin/dataloader#106