Update is_list_dtype to handle additional types
#250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cudf version does not return the expected type for a cupy list
oliverholworthy
commented
Mar 20, 2023
| return cudf_is_list_dtype(ser) | ||
| elif cudf and isinstance(ser, cp.ndarray): | ||
| return pd.api.types.is_list_like(ser[0]) |
There was a problem hiding this comment.
Using pandas is_list_like to check cupy array instead of equivalent in cudf because it doesn't match the pandas version (See: rapidsai/cudf#12975 )
karlhigley
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #244 . Extending the types supported by
is_list_dtype. This wasn't caught in the previous PR because we only ran the NVTabular tests on CPU. There are cases when this function is called bycupy.ndarrayandcudf.ListDTypevalues.The docstring for this function and variable name implied that this function was intended to be used only for series types.