Make ColumnSelector.all a property instead of a manually set attribute
#296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be causing situations where `ColumnSelector.all` doesn't exist, though I'm not entirely sure how. In any case, making it a property is a better design anyway, so let's see if this fixes the issues.
Documentation preview |
| def test_wildcard_selector_bool(): | ||
| selector = ColumnSelector("*") | ||
|
|
||
| assert selector.all is True |
There was a problem hiding this comment.
It looks like this test would have passed without this change. I'm not sure if this PR has a functional change, though the property method is clearer in terms of documenting the public interface.
There was a problem hiding this comment.
I'm right there with you on thinking this shouldn't be a functional change, but if you see the linked bug ticket, somehow self.all is not getting set/created on selector objects. I think this should address that issue, although I'm not entirely sure why the code wasn't working as written.
oliverholworthy
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be causing situations where
ColumnSelector.alldoesn't exist, though I'm not entirely sure how. In any case, making it a property is a better design anyway, so let's see if this fixes the issues.