Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add problem matcher for actionlint to annotate errors #315

Merged
merged 6 commits into from
May 10, 2023

Conversation

oliverholworthy
Copy link
Member

@oliverholworthy oliverholworthy commented May 9, 2023

@oliverholworthy oliverholworthy self-assigned this May 9, 2023
@oliverholworthy
Copy link
Member Author

Added a temporary commit to check the annotations show up in the code view

image

@github-actions
Copy link

github-actions bot commented May 9, 2023

Documentation preview

https://nvidia-merlin.github.io/core/review/pr-315

"owner": "actionlint",
"pattern": [
{
"regexp": "^(?:\\x1b\\[\\d+m)?(.+?)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*: (?:\\x1b\\[\\d+m)*(.+?)(?:\\x1b\\[\\d+m)* \\[(.+?)\\]$",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You speak regex at an impressive level of fluency! I gave up trying to understand what this does after about 10 characters. 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karlhigley karlhigley merged commit b0da0cd into NVIDIA-Merlin:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants