Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle schema inference in Dataset with empty list col #319

Merged
merged 3 commits into from
May 12, 2023

Conversation

oliverholworthy
Copy link
Member

Handle schema inference in Dataset with empty list col.

We currently get a StopIteration exception when a Dataset is constructed on CPU with a data where the first row is an empty list.

This PR updates the inference of the schema to return an unknown dtype if we can't find a value

@oliverholworthy oliverholworthy added the chore Maintenance for the repository label May 12, 2023
@oliverholworthy oliverholworthy added this to the Merlin 23.05 milestone May 12, 2023
@oliverholworthy oliverholworthy self-assigned this May 12, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/core/review/pr-319

@karlhigley karlhigley merged commit e1eaf26 into NVIDIA-Merlin:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants